From fcd4b4477a2c8184eeac8a975137e2f1a2d6b1df Mon Sep 17 00:00:00 2001 From: Kashyap Chamarthy Date: Thu, 3 Apr 2025 00:40:33 +0200 Subject: [PATCH] tests: skip the 'dc-compute' test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-type: text/plain This test fails on riscv64 hardware (SiFive P550) with the below error, due to an unrelated GCC issue. The actual error message: [...] ../../tests/dh-compute.c: In function 'params': ../../tests/dh-compute.c:56:15: internal compiler error: in cmp_csts_same_type, at analyzer/svalue.cc:466 56 | ret = gnutls_dh_params_import_raw3(*dh_params, p, q, g); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [...] Daiki Ueno pointed out that it could be due to this bug[1]. [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119278 — [15 Regression] ICE on gnutls-3.8.9: in cmp_csts_same_type, at analyzer/svalue.cc:466 since r15-8016-g8015a72ae49640 Thanks: Andrea Bolognani , for testing it and discovering the failure. Signed-off-by: Kashyap Chamarthy --- configure.ac | 7 +++++++ tests/Makefile.am | 6 ++++++ 2 files changed, 13 insertions(+) diff --git a/configure.ac b/configure.ac index 27db8f2ee8030df214dd5db4b1246e4449c8388b..5ac3c0b79c2eebb81a24f462fbc1b4e2cf1d82ba 100644 --- a/configure.ac +++ b/configure.ac @@ -153,6 +153,13 @@ if test "$use_cxx" != "no"; then fi AM_CONDITIONAL(ENABLE_CXX, test "$use_cxx" != "no") +# This fails on riscv64; see +# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119278 +AC_ARG_ENABLE([dh-compute-test], + AS_HELP_STRING([--disable-dh-compute-test], [disable the 'dh-compute' test]), + [enable_dh_compute_test=$enableval, enable_dh_compute_test=yes) +AM_CONDITIONAL([ENABLE_DH_COMPUTE_TEST], [test "x$enable_dh_compute_test" != "no"]) + dnl Detect windows build use_accel=yes have_vista_dynamic=yes diff --git a/tests/Makefile.am b/tests/Makefile.am index b39a97bac364f41da5cc7a5ec49952f63ecbb307..32d1e4a314c326a4916dd3e0c538cb3e9a7dc60a 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -671,6 +671,12 @@ else TESTS_ENVIRONMENT += ENABLE_GOST=0 endif +if ENABLE_DH_COMPUTE_TEST +TESTS_ENVIRONMENT += ENABLE_DH_COMPUTE_TEST=1 +else +TESTS_ENVIRONMENT += ENABLE_DH_COMPUTE_TEST=0 +endif + TESTS_ENVIRONMENT += \ FAKETIME="$(FAKETIME)" \ FAKETIME_F_OPT="$(FAKETIME_F_OPT)" \ -- 2.49.0